From 3664bd2a8da6a6e683ffd9bba1e68eb52078771f Mon Sep 17 00:00:00 2001 From: Mihai <961778+mihaicodrean@users.noreply.github.com> Date: Sat, 25 Mar 2023 23:59:06 +0200 Subject: [PATCH] Fixed the DsFreeSpnArray function signature, as it was corrupting the native heap. (#382) --- PInvoke/NTDSApi/NTDSAPI.cs | 2 +- UnitTests/PInvoke/NTDSApi/NTDSApiTests.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/PInvoke/NTDSApi/NTDSAPI.cs b/PInvoke/NTDSApi/NTDSAPI.cs index 08197561..4951ef48 100644 --- a/PInvoke/NTDSApi/NTDSAPI.cs +++ b/PInvoke/NTDSApi/NTDSAPI.cs @@ -1545,7 +1545,7 @@ namespace Vanara.PInvoke // *rpszSpn ); [DllImport(Lib.NTDSApi, SetLastError = false, CharSet = CharSet.Auto)] [PInvokeData("ntdsapi.h", MSDNShortId = "1c229933-432d-4ded-be3b-3bd339a0abe4")] - public static extern void DsFreeSpnArray(uint cSpn, ref SpnArrayHandle rpszSpn); + public static extern void DsFreeSpnArray(uint cSpn, SpnArrayHandle rpszSpn); /// /// The DsGetDomainControllerInfo function retrieves data about the domain controllers in a domain. diff --git a/UnitTests/PInvoke/NTDSApi/NTDSApiTests.cs b/UnitTests/PInvoke/NTDSApi/NTDSApiTests.cs index 3fb568b3..ac6f8467 100644 --- a/UnitTests/PInvoke/NTDSApi/NTDSApiTests.cs +++ b/UnitTests/PInvoke/NTDSApi/NTDSApiTests.cs @@ -84,7 +84,7 @@ namespace Vanara.PInvoke.Tests uint uSpn = 1; ret = DsGetSpn(DS_SPN_NAME_TYPE.DS_SPN_NB_HOST, "cxhndl", null, 0, 0, null, null, ref uSpn, out var hA); ret.ThrowIfFailed(); - DsFreeSpnArray(uSpn, ref hA); + DsFreeSpnArray(uSpn, hA); } [Test]