From 7a0acde55227a0645410dbe786e780349d8516be Mon Sep 17 00:00:00 2001 From: David Hall Date: Sat, 10 Aug 2019 13:51:36 -0600 Subject: [PATCH] Finished unit testing and updates for ntsecapi.h audit functions --- PInvoke/Security/AdvApi32/NTSecApi.Audit.cs | 6 +++--- UnitTests/PInvoke/Security/AdvApi32/AuditTests.cs | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/PInvoke/Security/AdvApi32/NTSecApi.Audit.cs b/PInvoke/Security/AdvApi32/NTSecApi.Audit.cs index d685175e..d008be34 100644 --- a/PInvoke/Security/AdvApi32/NTSecApi.Audit.cs +++ b/PInvoke/Security/AdvApi32/NTSecApi.Audit.cs @@ -653,12 +653,12 @@ namespace Vanara.PInvoke /// /// /// To successfully call this function, the caller must have SeSecurityPrivilege. - // https://docs.microsoft.com/en-us/windows/desktop/api/ntsecapi/nf-ntsecapi-auditquerysecurity BOOLEAN AuditQuerySecurity( - // SECURITY_INFORMATION SecurityInformation, PSECURITY_DESCRIPTOR *ppSecurityDescriptor ); + // https://docs.microsoft.com/en-us/windows/win32/api/ntsecapi/nf-ntsecapi-auditquerysecurity + // BOOLEAN AuditQuerySecurity( SECURITY_INFORMATION SecurityInformation, PSECURITY_DESCRIPTOR *ppSecurityDescriptor ); [DllImport(Lib.AdvApi32, SetLastError = true, ExactSpelling = true)] [PInvokeData("ntsecapi.h", MSDNShortId = "496c9659-0c03-42c9-93c4-eb4d97e950e2")] [return: MarshalAs(UnmanagedType.U1)] - public static extern bool AuditQuerySecurity(SECURITY_INFORMATION SecurityInformation, out PSECURITY_DESCRIPTOR ppSecurityDescriptor); + public static extern bool AuditQuerySecurity(SECURITY_INFORMATION SecurityInformation, out SafePSECURITY_DESCRIPTOR ppSecurityDescriptor); /// The AuditQuerySystemPolicy function retrieves system audit policy for one or more audit-policy subcategories. /// diff --git a/UnitTests/PInvoke/Security/AdvApi32/AuditTests.cs b/UnitTests/PInvoke/Security/AdvApi32/AuditTests.cs index 4b2375e0..02692c82 100644 --- a/UnitTests/PInvoke/Security/AdvApi32/AuditTests.cs +++ b/UnitTests/PInvoke/Security/AdvApi32/AuditTests.cs @@ -121,7 +121,7 @@ namespace Vanara.PInvoke.Tests public void AuditQuerySetSecurityTest() { Assert.That(AuditQuerySecurity(SECURITY_INFORMATION.SACL_SECURITY_INFORMATION, out var sd), Is.True); - Assert.That(sd.IsNull, Is.False); + Assert.That(sd.IsInvalid, Is.False); Assert.That(AuditSetSecurity(SECURITY_INFORMATION.SACL_SECURITY_INFORMATION, sd), Is.True); }