From 26d6d62cbedf1ceac12e8f9d6ade661718caaadd Mon Sep 17 00:00:00 2001 From: Johan Ouwerkerk Date: Mon, 27 Jan 2020 22:40:17 +0100 Subject: [PATCH] Validate that an account secret is valid base32. --- autotests/account/validation/account-validation.cpp | 2 +- src/account/validation.cpp | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/autotests/account/validation/account-validation.cpp b/autotests/account/validation/account-validation.cpp index 32ce9d8..47b91f9 100644 --- a/autotests/account/validation/account-validation.cpp +++ b/autotests/account/validation/account-validation.cpp @@ -80,7 +80,7 @@ void AccountValidationTest::checkSecret_data() QTest::newRow("null value") << QString() << false; QTest::newRow("empty secret") << QString(QLatin1String("")) << false; - QTest::newRow("valid secret") << QString(QLatin1String("something")) << true; + QTest::newRow("valid secret") << QString(QLatin1String("ONSWG4TFOQ======")) << true; } void AccountValidationTest::checkTokenLength_data() diff --git a/src/account/validation.cpp b/src/account/validation.cpp index 49413f4..81074f5 100644 --- a/src/account/validation.cpp +++ b/src/account/validation.cpp @@ -4,6 +4,8 @@ */ #include "validation.h" +#include "../base32/base32.h" + namespace accounts { @@ -14,7 +16,7 @@ namespace accounts bool checkSecret(const QString &secret) { - return !secret.isEmpty(); + return !secret.isEmpty() && base32::validate(secret); } bool checkName(const QString &name)