sean-m
/
McRule
mirror of https://github.com/sean-m/McRule.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Code coverage gaming.

pull/5/head
Sean McArde 2023-07-24 14:19:12 -07:00
parent 7f623d9c87
commit 76ff0b8201
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
McRule.Tests/Filtering.cs
View File

@ -12,7 +12,7 @@ namespace McRule.Tests {
new People("Ferris", "Student", 17, true, new[] {"muggle"}),
};
public record People(string name, string kind, int number, bool stillWithUs, string[] tags = null);
public record People(string name, string kind, int? number, bool stillWithUs, string[] tags = null);
ExpressionPolicy notSean = new ExpressionPolicy {
Name = "Not named Sean",
@ -175,6 +175,7 @@ namespace McRule.Tests {
[Test]
public void NullFilterWhenNoMatchingTypes() {
// Shouldn't have any filters in the policy for string objects.
var filter = notQuiteDead.GetExpression<string>()?.Compile();
Assert.Null(filter);
@ -185,11 +186,11 @@ namespace McRule.Tests {
var filter = deadOrViking.GetExpression<People>()?.Compile();
var folks = things.Where(filter);
Assert.NotNull (folks);
Assert.NotNull(folks);
Assert.NotNull(folks.Where(x => x.kind == "Viking" && x.stillWithUs == false));
Assert.NotNull(folks.Where(x => x.kind == "Viking" && x.stillWithUs == true));
// Should be either a viking or dead, not neither
// Should be either a viking or dead, not neither.
Assert.Null(folks.FirstOrDefault(x => x.kind != "Viking" && x.stillWithUs == true));
}
}

3
McRule/PredicateExpressionPolicyExtensions.cs
View File

@ -27,8 +27,7 @@ public static class PredicateExpressionPolicyExtensions {
if (!(filterType == "StartsWith" || filterType == "EndsWith" || filterType == "Contains" || filterType == "Equals"))
{
throw new Exception($"filterType must equal StartsWith, EndsWith or Contains. Passed {filterType}");
}
}
#endif
// Check that the property isn't null, otherwise we'd hit null object exceptions at runtime
var notNull = Expression.NotEqual(lambda.Body, Expression.Constant(null));