Commit Graph

17 Commits (d0133155d6d43f93dc74e4b13ae9bf64677c415b)

Author SHA1 Message Date
Abbas Cyclewala d0133155d6
* Updated dependecies (#394)
* * Updated dependecies
* fixed build error
* removed obsolete code

* fixed coverage threshold

* updated changelog

* removed key hashing as it can lead to conflicts

* updated container image
2022-10-01 10:23:01 +05:30
Steven Frew a74f73a44e
suggested fix for issue #384 (#386)
* fix for ruleparameter name changes against cached rules

* fixed indentation to match rest of code

* suggested change implemented
2022-09-05 09:14:18 +05:30
Abbas Cyclewala 571490455c
Abbasc52/combined fixes (#341)
* Fixed actions not working with complex objects

* removed Microsoft.Extensions.Caching dependency

* * updated nuget packages
* update dotnet version to 6 for demo/test proj
* improved integration with DynamicLinq

* added test case for jsonElement getProperty method

* updated test cases to cover case insensitivity

* updated workflow schema

* added schema for list of workflows

* fixed schema name and added to solution

* Update dotnetcore-build.yml

* Update dotnetcore-build.yml

* updated unit test proj to point to dotnet 6

* removed ilogger
2022-04-12 19:24:16 +05:30
Anton Kheystver 53213bf13e
Add ContainsWorkflow method to check if workflow exists (#283)
* Add ContainsWorkflow method to check if workflow exists

* Add method to interface

Co-authored-by: anton.kheystver <anton.kheystver@opensoftdev.ru>
2021-11-25 21:02:21 +05:30
Abbas Cyclewala 108fa91968
Enhancements (#282)
* * fixed workflowInjection not working
* added optional Inputs filter for EvaluateRuleAction

* * ActionContext now supports optional inputs
* Added support to pass additionalInputs to EvaluateRule Action
2021-11-23 17:47:10 +05:30
Alex Reich 34f77ed2ec
Make consistent singlar/plural names of instances to avoid downstream… (#193)
* Make consistent singlar/plural names of instances to avoid downstream ambiguous reference issues

* Reverted ReSettings pluralization

* conventional progress

* Overhaul to simplify, cleanup, deprecate pr

* Update README.md

* Reverted RuleActions

* Cleanup

* Cleanup

* Cleanup

* Cleanup

* Deprecate RuleAction to plural

* Reverted some name changes per @abbasc52

* Clarity + VS.NET 2019 compilation fix

* Camelcase fixes

* Reverted Id properties

* Documentation updates

Co-authored-by: Alex Reich <Alex_Reich@mechanicsbank.com>
Co-authored-by: Alex Reich <alex@alexreich.com>
Co-authored-by: Abbas Cyclewala <abcy@microsoft.com>
2021-08-13 10:04:47 +05:30
Abbas Cyclewala b763f718bc
Abbasc52/actions for nested levels (#182)
* Added support for nested rule actions

* Changed type for Actions
2021-07-20 16:54:32 +05:30
Abbas Cyclewala ec172c9b0f
made AddWorkflow throw exception when trying to add an workflow which already exists (#162) 2021-06-08 09:21:02 +05:30
Ashish Prasad 77ed54aca7
[158] Refresh compiled rules if stale. (#159)
* [158] Refresh compiled rules if stale.

* 1. AddWorkflow should update only new rules.
1. Change to `AreCompiledRulesUpToDate`.
1. Add test cases:
  1. AddWorkflow executing previous rules.
  1. AddOrUpdateWorkflow executing new rules.

* 1. [Typo] result2 should be aserted instead of result1.

1. [NIT] Assert previousResults and newResults instead of expected and actual.

* Validate rules first before checking if the workflow name is not already added..

Co-authored-by: Ashish Prasad <ashprasa@microsoft.com>
2021-06-07 05:48:21 +00:00
Abbas Cyclewala f3ac4316df
Abbasc52/null rule param fix (#119)
* Fixed scoped parameter throwing exception on compilation error
* Fixed null RuleParameter throwing exception
* Replaced thrown Exceptions with RuleException
2021-04-19 11:21:33 +05:30
Abbas Cyclewala b49ffd207d
Abbasc52/nested fix (#96)
- Added GlobalParams support #97
- LocalParams now work at all nested levels #98
- Added Enabled field to Rule to enable/disable a Rule #99
- Fixed Rule compilation error not appearing as error message in certain cases #95
2021-02-02 10:29:21 +05:30
Abbas Cyclewala 04060e7159
Fixed LocalParams Cache not getting cleaned up (#93) 2021-01-21 16:09:25 +05:30
Abbas Cyclewala 9c8b9d484e
* fixed namespace issue (#82)
* fixed namespace issue
* added editorconfig
* cleaned up files based on editorconfig
2020-12-23 11:04:10 +05:30
Abbas Cyclewala a90880f126
perf improvements and benchmarking (#70)
* added perf improvements

* Added benchmark tool
2020-11-16 14:06:35 +05:30
Abbas Cyclewala b68861dfd5
Merge develop to master (#68)
* Users/abbasc52/add-actions (#56)

* Removed ruleinput

* Simplified compiled params code

* clean up and renaming

* Fixed caching and made test cases more specific

* updated settings

* updated nuget and fix warnings

* Added test case for invalid input name

* changed input from object to dictionary

* Added action related fields and added expression output action

* Added evaluateRuleAction and added basic tests for actions

* made action names and context case insensitive

* Added exception handling

* fixed exception message for parsing error

* improved constructor for action factory

* Added build trigger for pr to develop

* Added more testcases for actions

* Shared same instance of parser for RulesEngine and OutputExpression action

* fixed review comments

* Added null check for actions not mentioned in json

* pull fixes from master (#61)

* Renamed ExecuteRule to ExecuteAllRulesAsync and added action support (#63)

* Added support for actions
* Renamed ExecuteRule to ExecuteAllRulesAsync

* added github nuget publish
2020-11-02 09:25:43 +05:30
Abbas Cyclewala c0488f1113
Moving latest changes in develop and reverting them from master (#41)
* Revert "Increased coverage threshold to 95 for PR"

This reverts commit b545c5b4cf.

* Revert "Converted expressions to delegates and code cleanup (#34)"

This reverts commit 75baa6e358.
2020-08-28 07:44:00 +05:30
Abbas Cyclewala 75baa6e358
Converted expressions to delegates and code cleanup (#34)
* Converted expressions to delegate and code cleanup

* fixed test cases
2020-08-04 10:29:02 +05:30